Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup basic infrastructure to ensure destroyables destroyed #19787

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Oct 12, 2021

The @glimmer/destroyables package (which is re-exported here as @ember/destroyable) provides a handy utility that we can use to ensure that all objects that were setup with the destruction system have actually had destroy called on them. Read up over in emberjs/rfcs#580 for details on the enableDestroyableTracking and assertDestroyablesDestroyed methods (or destroyables in general).

This PR adds the basic ability to begin enforcing that our own test suite properly calls destroy on everything that has a destructor setup on it, this is a basic precursor to exposing the same utility to application test harnesses. At the moment, applications cannot leverage the assertDestroyablesDestroyed functionality themselves, due to framework objects themselves. This PR allows us to begin fixing that...

References

@rwjblue rwjblue force-pushed the assert-destroyables branch from 4f2a205 to 632f020 Compare October 14, 2021 15:00
@rwjblue rwjblue merged commit ec26560 into master Oct 22, 2021
@rwjblue rwjblue deleted the assert-destroyables branch October 22, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant